remove get_val in serialization #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove get_val in serialization and mark as unimplemented!() replace get_val with iter in linear codec remove MultivalueStartIndexRandomSeeker replace MultivalueStartIndexIter with closure Sample 100 values in linear codec
fulmicoton
reviewed
Oct 4, 2022
| .collect::<Vec<_>>(); | ||
| let limit_num_vals = column.num_vals().min(100_000); | ||
|
|
||
| let num_samples = 100; |
There was a problem hiding this comment.
I like the step_by solution.
Can you change the column.num_vals() limit above to 100 too, to make proofreading even easier.
There was a problem hiding this comment.
I don't understand, 100 instead of 100_000?
fulmicoton
reviewed
Oct 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #1587 +/- ##
==========================================
- Coverage 93.79% 93.75% -0.04%
==========================================
Files 251 251
Lines 46329 46278 -51
==========================================
- Hits 43456 43390 -66
- Misses 2873 2888 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fulmicoton
reviewed
Oct 4, 2022
Comment on lines
+258
to
+261
| if old_doc == u32::MAX { | ||
| // sentinel value for last offset | ||
| return offset; | ||
| } |
There was a problem hiding this comment.
wouldn't doing the chain below do the same thing?
doc_id_map
.iter_old_doc_ids()
.map(move |old_doc| { ... })
.chain(iter::once(offset))
There was a problem hiding this comment.
It would, but offset is already owned by the closure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove get_val in serialization and mark as unimplemented!()
replace get_val with iter in linear codec
remove MultivalueStartIndexRandomSeeker
replace MultivalueStartIndexIter with closure
Sample 100 values in linear codec
remove Mutexes